-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support external redis host and using 127.0.0.1 as default #196
Conversation
I believe this requirement is reasonable; thank you for submitting this Pull Request. At the same time, I would like to discuss an issue with you: If we use an external Redis Server, should we support databases so that multiple Oryx instances can use the same Redis, isolating data through the DB parameter? redis.NewClient(&redis.Options{Addr, Password, DB: 0}) If you think it's reasonable, then please add an environment variable
|
Ok I think we can do this. Let me make the changes |
This comment was marked as off-topic.
This comment was marked as off-topic.
I've also attempted to run this docker with my modifications, but I noticed even if I have my own redis setup, oryx will attempt to create it's own redis server. How should we face this issue? Do you have any ideas? |
Same problem |
This issue is not related to this pull request. Please submit a separate issue with detailed information about it.
|
This environment variable simply determines which Redis server Oryx connects to. However, Oryx will always create its own Redis server. This should not affect the final outcome, as it consumes very minimal resources and remains unused.
|
I have created a seperate issue with screenshots detailing the issue. Thanks @winlinvip |
I want to use my external redis because after many hours of streaming and recording oryx stops working. There are many keys written that get cleaned only after you delete the recording task.
I would like to be able to use my custom redis to support more intensive recordings